feat: add workflow for node execution by cbermudez97 · Pull Request #267 · NethermindEth/nethermind-arbitrum

cbermudez97 · 2025-09-26T17:52:22Z

No description provided.

…ro services

…mmand formatting

…a generation

… generation

…data generation

…e configuration

…n URL handling

# Conflicts: # src/Nethermind.Arbitrum/Properties/configs/arbitrum-sepolia-archive.json # src/Nethermind.Arbitrum/Properties/configs/arbitrum-sepolia.json

Copilot

Pull request overview

This PR adds comprehensive infrastructure for executing Arbitrum nodes with automated workflow orchestration. The implementation includes configuration updates for block processing timeouts, block hash verification settings, and a complete CI/CD pipeline for deploying and managing custom nodes.

Key Changes:

Updated Arbitrum mainnet configurations with new block processing timeouts (60000ms) and block hash verification settings
Added GitHub Actions workflow for deploying custom nodes with configurable parameters (chain selection, timeout, SSH keys, firewall rules)
Implemented Python script for generating node deployment configurations with Docker Compose orchestration for Nethermind and Nitro services

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
`src/Nethermind.Arbitrum/Properties/configs/arbitrum-mainnet.json`	Adds Arbitrum and VerifyBlockHash configuration sections with block processing timeout and verification settings
`src/Nethermind.Arbitrum/Properties/configs/arbitrum-mainnet-archive.json`	Updates block processing timeout to 60000ms and adds VerifyBlockHash configuration
`scripts/wait_for_workflow.sh`	Implements workflow monitoring script that waits for GitHub Actions workflows to trigger and complete
`scripts/setup_script.sh.j2`	Jinja2 template for node setup including Docker installation, registry authentication, and container orchestration
`scripts/generate_custom_node_data.py`	Python script generating deployment configurations for Nethermind and Nitro nodes with environment-based configuration
`.github/workflows/run-node.yml`	GitHub Actions workflow orchestrating node deployment with inputs for images, chain selection, and security settings
`.editorconfig`	Adds Python-specific indentation settings (4 spaces)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/run-node.yml

Copilot · 2025-12-27T16:30:24Z

scripts/setup_script.sh.j2

+echo "Installing Docker..."
+## Add Docker's official GPG key:
+sudo apt-get update
+sudo apt-get install ca-certificates curl


The command options for apt-get install should include the -y flag for non-interactive installation, similar to lines 23 and 27. Without it, the installation may prompt for user confirmation and hang the script.

Suggested change

sudo apt-get install ca-certificates curl

sudo apt-get install -y ca-certificates curl

scripts/setup_script.sh.j2

scripts/generate_custom_node_data.py

scripts/wait_for_workflow.sh

Copilot · 2025-12-27T16:30:27Z

scripts/generate_custom_node_data.py

+    pushgateway_url: str = "",
+    seq_url: str = "",
+    seq_api_key: str = "",
+    # TODO: Add more flags options as needed


The comment "TODO: Add more flags options as needed" suggests incomplete functionality. If this is intentional for future expansion, consider removing the TODO or creating a tracking issue for the additional flags that need to be implemented.

Suggested change

# TODO: Add more flags options as needed

# Additional Nethermind flag options can be added here if required in the future.

Copilot · 2025-12-27T16:30:27Z

scripts/setup_script.sh.j2

+
+# Docker login
+echo "Logging in to Docker registry..."
+docker login {{ docker_registry.url }} -u "{{ docker_registry.username }}" -p "{{ docker_registry.password }}"


The docker login command uses the -p flag with {{ docker_registry.password }} directly on the command line, which exposes the registry password in the process list to any local user or monitoring system and can also surface in host-level telemetry. An attacker with local access could capture these credentials and use them to pull or push images or otherwise impersonate the registry account. Use a method that does not place the password in the command line (for example, passing it via standard input) so the secret is never visible in process arguments or logs.

Suggested change

docker login {{ docker_registry.url }} -u "{{ docker_registry.username }}" -p "{{ docker_registry.password }}"

printf '%s\n' '{{ docker_registry.password }}' | docker login {{ docker_registry.url }} -u "{{ docker_registry.username }}" --password-stdin

github-actions · 2025-12-27T16:31:08Z

Package	Line Rate	Branch Rate	Health
Nethermind.Arbitrum	80%	57%	✔
Summary	80% (8242 / 10270)	57% (1985 / 3483)	✔

Minimum allowed line rate is 60%

cbermudez97 self-assigned this Sep 26, 2025

AnkushinDaniil force-pushed the feat/run-node-workflow branch from a964d51 to b5540b1 Compare October 1, 2025 12:41

cbermudez97 and others added 28 commits December 27, 2025 20:15

feat: add base workflow for node execution

0847f40

feat: add nethermind and nitro services docker compose configs

130b1c6

fix: update nethermind command for sepolia to use archive version

a715fde

chore: update jinja2 installation to include jinja2-ansible-filters

63ca2fd

fix: add jinja2-ansible-filters extension to template rendering

407d6f3

refactor: improve setup script generation

95c86ea

chore: add debug output for custom node data in workflow

6d81133

chore: update custom node data keys and improve workflow command

642d96d

chore: update custom machine type for sepolia in node data generation

d43fdb3

chore: enhance docker compose and setup script for nethermind and nit…

6a9e100

…ro services

feat: add pushgateway url to nethermind configuration and clean up co…

ce7b9de

…mmand formatting

feat: add instance name for metrics identification in custom node dat…

c1c9011

…a generation

fix: include instance name parameter in nethermind config function

00c9be9

chore: update workflow reference to main in run-node configuration

47b731f

fix: update nitro configuration paths and volumes in custom node data…

5f16eab

… generation

feat: add healthcheck and update depends_on condition in custom node …

5433461

…data generation

feat: add seq url and api key to custom node configuration

74a2af7

fix: update workflow reference to use dynamic workflow ref in run-nod…

1f56793

…e configuration

fix: add nitro data directory setup in script

dffe886

add flags

17c9693

feat: enhance run-node workflow with mainnet support and dynamic chai…

5a1aa29

…n URL handling

feat: add mainnet machine type and update nethermind command for mainnet

3ce35c7

disable restart

8ad9ad7

fix

61eb246

upd

3ec4f05

# Conflicts: # src/Nethermind.Arbitrum/Properties/configs/arbitrum-sepolia-archive.json # src/Nethermind.Arbitrum/Properties/configs/arbitrum-sepolia.json

fix

3c0b2d4

fix

a5b2591

change to external

1fe4d53

upd

d8067f8

AnkushinDaniil force-pushed the feat/run-node-workflow branch from 862a903 to d8067f8 Compare December 27, 2025 16:25

AnkushinDaniil marked this pull request as ready for review December 27, 2025 16:25

Copilot AI review requested due to automatic review settings December 27, 2025 16:25

AnkushinDaniil requested review from AnkushinDaniil, damian-orzechowski, hudem1, svlachakis, tanishqjasoria and wurdum as code owners December 27, 2025 16:25

Copilot started reviewing on behalf of AnkushinDaniil December 27, 2025 16:26 View session

Copilot AI reviewed Dec 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: add workflow for node execution#267

feat: add workflow for node execution#267
cbermudez97 wants to merge 29 commits intomainfrom
feat/run-node-workflow

cbermudez97 commented Sep 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	sudo apt-get install ca-certificates curl
	sudo apt-get install -y ca-certificates curl

	# TODO: Add more flags options as needed
	# Additional Nethermind flag options can be added here if required in the future.

	docker login {{ docker_registry.url }} -u "{{ docker_registry.username }}" -p "{{ docker_registry.password }}"
	printf '%s\n' '{{ docker_registry.password }}' \| docker login {{ docker_registry.url }} -u "{{ docker_registry.username }}" --password-stdin

Comments

Conversation

cbermudez97 commented Sep 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants