-
Notifications
You must be signed in to change notification settings - Fork 10
doc: revamp preconf struct and validation #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
552e2ee to
63bbb00
Compare
docs/permissionless-design-doc.md
Outdated
| anchorHash = L1.getBlockHash(preconf.anchorId) | ||
| anchorTx = constructAnchorTx(anchorHash) | ||
| l2Block = executeL2Block([anchorTx] + rawTxList) | ||
| l2Block = executeL2Block( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we also add:
def executeL2Block(// ...):
// ...
here, to define the L2 preconf block derivation process from a commitment in code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In latest ver I have redone the python code to better connect with the derivation process in Rust. Didn't define the whole derivation process, but hopefully it helps with agreeing on how to connect with the derivation
63bbb00 to
51fcc4a
Compare
Add three new fields to the Preconfirmation struct: - timestamp: Timestamp of the preconfed block - gasLimit: Gas limit for the preconfed block - coinbase: Coinbase address (recipient of block rewards) Update slashing section to include these fields in mismatch detection. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
51fcc4a to
5f9f6ad
Compare
5f9f6ad to
d0f9232
Compare
MatusKysel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Uh oh!
There was an error while loading. Please reload this page.