HA: minor fixes #1272
Merged
HA: minor fixes #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cluster has been re-initialized after a reset, keepalived was kept in disabled state and was not starting at boot
When using "ns-ha-config upgrade-remote <img>", make sure the img file is present. Previously, the command was reporting a success while the upgrade did not really take place.
Display API error, if any
Tbaile
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
packages/ns-api/files/ns.ha: Added a step to enablekeepalivedin theinit_localfunction to ensure it is active if previously disabled by the reset API.packages/ns-api/files/ns.ha: Added a check in theupgrade_remotefunction to return an error if the specified image file does not exist, preventing further processing.packages/ns-ha/files/ns-ha-config: Updated thens-ha-configscript to provide detailed error messages by parsing and displaying the error field from the RPC response when the upgrade fails.