Skip to content

fix(ns-storage): use filesystem label #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tbaile merged 18 commits into from
Jun 4, 2025
Merged

fix(ns-storage): use filesystem label #1234

Tbaile merged 18 commits into from
Jun 4, 2025

Conversation

@filippocarletti
Copy link
Member

@filippocarletti filippocarletti commented May 27, 2025 •
edited by Tbaile
Loading

We started off with: "Use ext4 label "ns_data" to identify storage disk/partition"
Now the PR does the following:

  • Replace UUID from disk used for logs to ns_data, complete with migration path
  • Added tune2fs package
  • Added script to check for disk mount
  • Added API to query disk mount status with previous mentioned script
  • Added alarm management through MY
  • Removing rsyslog write at boot if disk fails to mount

@filippocarletti
fix(ns-storage): use filesystem label
5d7828a 
Use ext4 label "ns_data" to identify storage disk/partition
@filippocarletti
Copy link
Member Author

filippocarletti commented May 27, 2025

#1233

@Tbaile Tbaile linked an issue May 27, 2025 that may be closed by this pull request
ns-storage can fill root filesystem #1233
Closed
@filippocarletti filippocarletti marked this pull request as ready for review May 28, 2025 16:18
@filippocarletti filippocarletti requested a review from Tbaile May 28, 2025 16:19
Tbaile
Tbaile reviewed May 29, 2025
View reviewed changes
@gsanchietti @Tbaile
fix(ns-storage): fix script comment
b8b53a1 
Co-authored-by: Bailetti Tommaso <tommaso.bailetti@nethesis.it>
@gsanchietti gsanchietti requested a review from Tbaile May 29, 2025 07:34
@Tbaile Tbaile force-pushed the ns-storage-label branch from e14d8e0 to e5007fb Compare May 29, 2025 10:10
@Tbaile Tbaile removed their request for review May 29, 2025 10:15
@Tbaile Tbaile requested a review from gsanchietti May 29, 2025 12:04
gsanchietti
gsanchietti reviewed May 29, 2025
View reviewed changes
gsanchietti
gsanchietti reviewed May 29, 2025
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add f2fs-tools tune2fs as dependency inside ns-storage Makefile

@Tbaile Tbaile requested a review from gsanchietti May 29, 2025 15:18
@Tbaile Tbaile requested a review from gsanchietti June 3, 2025 06:50
@Tbaile Tbaile merged commit 978c8ca into main Jun 4, 2025
1 check passed
@Tbaile Tbaile deleted the ns-storage-label branch June 4, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tbaile Tbaile Tbaile left review comments

@gsanchietti gsanchietti gsanchietti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ns-storage can fill root filesystem

4 participants

@filippocarletti @gsanchietti @Tbaile