feat(threatshield): active block list and ip search #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaile
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds new APIs for managing the threat shield active block list and IP search functionality, expanding the command dispatch and error handling capabilities.
- Introduces functions to parse IP expressions and sets, list active IP blocks, remove an active block, and search if an IP is blocked.
- Updates command mapping to include 'list-active-blocks', 'remove-active-block', and 'is-ip-blocked'.
Comments suppressed due to low confidence (2)
packages/ns-api/files/ns.threatshield:585
- The subprocess module is used in multiple functions but it is not imported in this file. Please add 'import subprocess' at the top of the file.
output_ipv4 = subprocess.run(["nft", "-j", "list", "set", "inet", "banIP", "blocklistv4"], check=True, capture_output=True, text=True)
packages/ns-api/files/ns.threatshield:602
- [nitpick] The sorting key using 'timeout - expires' is not immediately clear; please verify that this logic correctly reflects the intended ordering or add a comment to clarify the purpose.
blocks = sorted(blocks, key=lambda x: x["timeout"] - x["expires"])
gsanchietti
reviewed
May 7, 2025
gsanchietti
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added APIs for feature linked below
Ref: #924