feat: add high availability #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new high availability feature by generating PNG images from Graphviz dot files and ensuring that the Graphviz dependency is installed on the build system.
- Added a new section in conf.py to process dot files and generate PNG images.
- Updated the .readthedocs.yaml configuration to include the graphviz apt package.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf.py | Added code to generate PNG images from dot files in the _static directory. |
| .readthedocs.yaml | Updated build configuration to install the graphviz package. |
Files not reviewed (3)
- _static/high_availability.dot: Language not supported
- dns_dhcp.rst: Language not supported
- index.rst: Language not supported
gsanchietti
force-pushed
the
ha
branch
2 times, most recently
from
325082c to
e8f47e5
Compare
cotosso
reviewed
Jun 5, 2025
cotosso
reviewed
Jun 5, 2025
Co-authored-by: Davide Marini <cotosso@gmail.com>
Co-authored-by: Davide Marini <cotosso@gmail.com>
cotosso
reviewed
Jun 6, 2025
cotosso
reviewed
Jun 6, 2025
cotosso
reviewed
Jun 6, 2025
gsanchietti
commented
Jun 6, 2025
Co-authored-by: Davide Marini <cotosso@gmail.com>
cotosso
reviewed
Jun 6, 2025
Removed the optional gateway setting for the WAN interface, as it could create an unnecessary additional default route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue: NethServer/nethsecurity#920