Update Headers.java #1714
Open
Update Headers.java #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asMap() in zuul/message/Headers.java is related to many operations described as expensive (such as toString, hashing). Add a comment to asMap() to better communicate this expensive nature.
kyagna
reviewed
Dec 8, 2023
| @@ -581,7 +581,7 @@ public boolean equals(Object obj) { | |||
|
|
|||
| return asMap().equals(other.asMap()); | |||
| } | |||
|
|
|||
| /* asMap is an expensive function, use only when necessary. Avoid calling on a hot path. */ | |||
There was a problem hiding this comment.
couple of nits:
- Add a new line before the comment
- Can you make the comment multiline as in the next function to be consistent?
There was a problem hiding this comment.
Hi @kyagna, thanks for the feedback. I've adopted your suggestions to be more consistent and promote readability.
Style fix. 1. Added new line before asMap comment. 2. Converted asMap comment to a multiline comment.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asMap() in zuul/message/Headers.java is related to many operations described as expensive (such as toString, hashing). Add a comment to asMap() to better communicate this high computational complexity.