Repository navigation
Conversation
Avoids ambiguity that is reported by clang. Closes: Netflix#1616
|
Tested at d3eb8f4 merged onto master 6ec23e8 (clean), x86-64 Linux, gcc 16.2.1 with libstdc++, and a mingw-w64 cross build (g++ 16.2.0). Both build; release On the libc++ 23 The one behavioural difference to know about is that |
Apply Netflix/vmaf#1617 to fix an ambiguous call to swap when building with newer libc++ (__split_buffer). The pull requests has not yet been merged in upstream or Gentoo, so carry a local patch for now. BUG=b:568189402 TEST=emerge libvmaf with llvm-r614150 Change-Id: Ib854b62ac77b9d64f0715e85205abb56bebf1c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/8528106 Reviewed-by: Ryan Neph <ryanneph@google.com> Commit-Queue: Bob Haarman <inglorion@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org>
Apply Netflix/vmaf#1617 to fix an ambiguous call to swap when building with newer libc++ (__split_buffer). The pull requests has not yet been merged in upstream or Gentoo, so carry a local patch for now. BUG=b:568189402 TEST=emerge libvmaf with llvm-r614150 Change-Id: Ib854b62ac77b9d64f0715e85205abb56bebf1c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/8528106 Reviewed-by: Ryan Neph <ryanneph@google.com> Commit-Queue: Bob Haarman <inglorion@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org>
Apply Netflix/vmaf#1617 to fix an ambiguous call to swap when building with newer libc++ (__split_buffer). The pull requests has not yet been merged in upstream or Gentoo, so carry a local patch for now. BUG=b:568189402 TEST=emerge libvmaf with llvm-r614150 Change-Id: Ib854b62ac77b9d64f0715e85205abb56bebf1c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/8528106 Reviewed-by: Ryan Neph <ryanneph@google.com> Commit-Queue: Bob Haarman <inglorion@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org>
Instead of fighting the STL, embrace it 🔥
Avoids ambiguity with STL functions, as reported when building with clang.
Closes: #1616