Remove internal Hotspot metrics #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add comments
DanielThomas
force-pushed
the
dannyt/remove-hotspot-internal
branch
from
73b7964
to
e543420
Compare
brharrington
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PR on top of
dannyt/jfrto remove the Hotspot internal metrics. They're less of a concern for us now we're on ZGC, and most of the critical work happens in thread local handshakes, not safepoints, and JNI critical/GCLocker is less of a concern.Integrity by Default also means we want to move away from agents, opens, or any other practice that violates integrity. If we find another need for metrics for these, JFR is the way to do it now. We've long since removed the required
add-exportsfrom internal applications, because it prevents CDS from working.