ipc: add option to disable inflight #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inflight metrics are poorly modeled and can often be confusing. They do not aggregate as expected so aren't really meaningful unless you understand the full set of dimensions used. Add option to disable them. Cannot remove for now due to backwards compatibility.
manolama
added a commit
to manolama/spectator
that referenced
this pull request
Sep 13, 2024
Results in a `java.lang.NullPointerException: Cannot invoke "com.netflix.spectator.ipc.IpcLogger.inflightEnabled()" because "this.logger" is null`
manolama
added a commit
that referenced
this pull request
Sep 13, 2024
Results in a `java.lang.NullPointerException: Cannot invoke "com.netflix.spectator.ipc.IpcLogger.inflightEnabled()" because "this.logger" is null`
brharrington
pushed a commit
that referenced
this pull request
Sep 18, 2024
Results in a `java.lang.NullPointerException: Cannot invoke "com.netflix.spectator.ipc.IpcLogger.inflightEnabled()" because "this.logger" is null`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inflight metrics are poorly modeled and can often be confusing. They do not aggregate as expected so aren't really meaningful unless you understand the full set of dimensions used. Add option to disable them. Cannot remove for now due to backwards compatibility.