Use collections.abc for ABC import to fix Python 3.9 compatibility. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Much appreciated! Please refer to the contributing guide. We are aligning internally on how to make contributing to Metaflow easy and transparent. |
romain-intel
requested changes
Dec 11, 2019
metaflow/datastore/datastore.py
Outdated
| @@ -4,7 +4,10 @@ | |||
| import time | |||
| from hashlib import sha1 | |||
| from functools import partial | |||
| from collections import Sequence | |||
| try: | |||
There was a problem hiding this comment.
Actually, Sequence does not seem to be used anywhere in this file so maybe we can just remove the line and no add anything :).
There was a problem hiding this comment.
Thanks, I just did a find and replace. Removed the unused import now.
| @@ -11,7 +10,10 @@ | |||
| from urlparse import urlparse | |||
| except: | |||
| from urllib.parse import urlparse | |||
|
|
|||
| try: | |||
|
@tirkarthi Can you resolve the conflicts on this patch so that we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing ABC from collections module will raise
ImportErrorin Python 3.9 and raisesDeprecationWarningfrom 3.4 . Hence usecollections.abcand also preserve compatibility with Python 2. Ref : python/cpython#10596