Add support for class attributes and bound methods to escape hatch#2775
Open
Add support for class attributes and bound methods to escape hatch#2775
Conversation
wangchy27
reviewed
Jan 30, 2026
| if name == "function": | ||
| # Special handling of pickled functions. We create a new class that | ||
| if name in ("function", "method"): | ||
| # Special handling of pickled functions and methods. We create a new class that |
Collaborator
There was a problem hiding this comment.
what is the difference between method and function here? Does member means class member function?
Contributor
Author
There was a problem hiding this comment.
Yes method is a class instance method. I believe they should be handled the same as standalone functions but because the type is method instead of function, the escape hatch didn't recognize it and threw an error.
| obj = self._local_objects.get(obj.identifier) | ||
| if obj: | ||
| return obj | ||
| result = self._local_objects.get(obj.identifier) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the escape hatch to allow escaping the following components: