Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: better pip crossplatform resolves #2322

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Mar 3, 2025

⚠️ Proof-of-Concept. Do not merge ⚠️

for correctly resolving transient dependencies for cross-platform package resolves, where dependencies are conditional on platform/os such as

"nvidia-cuda-runtime-cu12 (==12.4.127) ; platform_system == \"Linux\" and platform_machine == \"x86_64\"",

This intends to solve an issue with packages such as the default torch where resolving on a mac, but deploying onto a linux-64 machine will result in a broken environment due to the conditional dependencies not getting bundled up.

Caveats:
pip has deprecated script wrappers and is pushing for module calls instead. This will make patching the sys values harder, and the current setup is bound to break in the future.

@saikonen
Copy link
Collaborator Author

saikonen commented Mar 3, 2025

note that for testing this, both .pip/metadata and conda.manifest local files for the involved flow need to most likely be cleared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant