Stop waiting for the status file when the process finishes #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids waiting for a long time after a process crashes when using the Runner or Deployer
savingoyal
previously approved these changes
Sep 13, 2024
romain-intel
commented
Sep 13, 2024
| start_time = time.time() | ||
| with open(file_path, "r", encoding="utf-8") as file_pointer: | ||
| content = file_pointer.read() | ||
| while not content: | ||
| if command_obj.process.poll() is not None: |
There was a problem hiding this comment.
There is technically a race here. I'll improve it slightly.
romain-intel
dismissed stale reviews from savingoyal and madhur-ob
via
bb8f72a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids waiting for a long time after a process crashes when using the Runner or Deployer