-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: run heartbeat with Argo daemon containers #1916
Conversation
…he argo heartbeat daemon
…mits to heartbeat daemon container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -846,6 +846,8 @@ def _compile_workflow_template(self): | |||
.templates(self._container_templates()) | |||
# Exit hook template(s) | |||
.templates(self._exit_hook_templates()) | |||
# Sidecar templates (Daemon Containers) | |||
.templates(self._daemon_container_templates()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this optional through the cli - —with-daemon-container/—no-with-daemon-container ? That way folks can opt out if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. One thought on the wording for the toggle though: Currently we only run heartbeats, and in the future some other run-scope-processes in the default container.
what happens with the toggle though, if we introduce a way for users to launch their own daemon containers alongside tasks? should these also not deploy if --no-with-daemon-container
is specified, or should it not apply to user defined ones?
…tainer resources significantly.
…rovider in daemon and use that to register a new run id, and to propagate heartbeats.
…run through the daemon as well.
Introducing run heartbeat updates as an argo daemon container to decouple workflow status from the active workflow pod health.