Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial runner api #1732

Merged
merged 55 commits into from
May 23, 2024
Merged

initial runner api #1732

merged 55 commits into from
May 23, 2024

Commits on May 21, 2024

  1. initial runner map api

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    90e1aea View commit details
    Browse the repository at this point in the history

  2. return Run objects

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a8cd6ab View commit details
    Browse the repository at this point in the history

  3. WIP: click to method mapping

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    89cb6eb View commit details
    Browse the repository at this point in the history

  4. WIP: click to method, adding groups

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    723e835 View commit details
    Browse the repository at this point in the history

  5. remove comment

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1d429de View commit details
    Browse the repository at this point in the history

  6. pass in args and opts correctly

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ef279d1 View commit details
    Browse the repository at this point in the history

  7. fix validation for top level params

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    682f6a0 View commit details
    Browse the repository at this point in the history

  8. restore metaflow_runner.py

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    37ba90d View commit details
    Browse the repository at this point in the history

  9. handle list in options

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d6fe8ac View commit details
    Browse the repository at this point in the history

  10. fix nargs

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    37bb394 View commit details
    Browse the repository at this point in the history

  11. fix issue with validating missing args

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5c255ef View commit details
    Browse the repository at this point in the history

  12. inject flow parameters as well

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d47cd75 View commit details
    Browse the repository at this point in the history

  13. handle include file

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7812e58 View commit details
    Browse the repository at this point in the history

  14. internal click to chaining methods functionality

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f958c68 View commit details
    Browse the repository at this point in the history

  15. subprocess manager

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    86968e6 View commit details
    Browse the repository at this point in the history

  16. simpler subprocess manager

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1c3c5bd View commit details
    Browse the repository at this point in the history

  17. handle SIGINT

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    61623cd View commit details
    Browse the repository at this point in the history

  18. wait() handles timeout + logs both

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    216c366 View commit details
    Browse the repository at this point in the history

  19. improved log streaming with ability to resume + stream multiple times

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    847822d View commit details
    Browse the repository at this point in the history

  20. cleanup in context manager, otherwise user is responsible

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    be5512e View commit details
    Browse the repository at this point in the history

  21. remove aiofiles

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4158db0 View commit details
    Browse the repository at this point in the history

  22. split into CommandManager and SubprocessManager

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b7d1083 View commit details
    Browse the repository at this point in the history

  23. return components array instead

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bf04383 View commit details
    Browse the repository at this point in the history

  24. remove assert

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    efa8750 View commit details
    Browse the repository at this point in the history

  25. add type hints

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cc6d602 View commit details
    Browse the repository at this point in the history

  26. return ExecutingRun encapsulating CommandManager and metaflow.Run

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9766d0f View commit details
    Browse the repository at this point in the history

  27. print as string

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    080fbb2 View commit details
    Browse the repository at this point in the history

  28. suggested improvements

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8a5a14f View commit details
    Browse the repository at this point in the history

  29. use correct variable name

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    04b8811 View commit details
    Browse the repository at this point in the history

  30. update usage of subprocess manager

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0cfc979 View commit details
    Browse the repository at this point in the history

  31. fix flags such as --pylint/--no-pylint

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b8ed331 View commit details
    Browse the repository at this point in the history

  32. cache loaded modules

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    73935b1 View commit details
    Browse the repository at this point in the history

  33. fix boolean flags

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d3f53aa View commit details
    Browse the repository at this point in the history

  34. remove aiofiles

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    79aeb4e View commit details
    Browse the repository at this point in the history

  35. no f-strings

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b8a47ac View commit details
    Browse the repository at this point in the history

  36. get run object explicitly

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    25f8ace View commit details
    Browse the repository at this point in the history

  37. new higher level UX

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    33c08c3 View commit details
    Browse the repository at this point in the history

  38. typeguard warning for 3.5/3.6 + add profile argument

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bafd29b View commit details
    Browse the repository at this point in the history

  39. default None for profile

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2128a22 View commit details
    Browse the repository at this point in the history

  40. detect early issues

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    95e7076 View commit details
    Browse the repository at this point in the history

  41. fix user defined params not being recognised

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1f20019 View commit details
    Browse the repository at this point in the history

  42. kill all descendants

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6b67548 View commit details
    Browse the repository at this point in the history

  43. do not use f-strings

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a77ba01 View commit details
    Browse the repository at this point in the history

  44. suggested changes

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5c8a9aa View commit details
    Browse the repository at this point in the history

  45. use pkill instead of psutil

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9a43517 View commit details
    Browse the repository at this point in the history

  46. minor fix

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    93dcd5c View commit details
    Browse the repository at this point in the history

  47. vendor typeguard

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    fc0ee63 View commit details
    Browse the repository at this point in the history

  48. update error message

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    471c335 View commit details
    Browse the repository at this point in the history

  49. remove comma and check in init

    @madhur-ob
    madhur-ob committed May 21, 2024
    Configuration menu
    Copy the full SHA
    706c00c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Added docstrings; fixed stubs; moved stuff around

    @romain-intel
    romain-intel committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c387d84 View commit details
    Browse the repository at this point in the history

  2. change dir name to runner

    @madhur-ob
    madhur-ob committed May 23, 2024
    Configuration menu
    Copy the full SHA
    737d2da View commit details
    Browse the repository at this point in the history

  3. fix import in test

    @madhur-ob
    madhur-ob committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4363d8f View commit details
    Browse the repository at this point in the history

  4. fix import

    @madhur-ob
    madhur-ob committed May 23, 2024
    Configuration menu
    Copy the full SHA
    fc1d92e View commit details
    Browse the repository at this point in the history

  5. add status property to ExecutingRun

    @madhur-ob
    madhur-ob committed May 23, 2024
    Configuration menu
    Copy the full SHA
    790e270 View commit details
    Browse the repository at this point in the history

  6. add docstring for status property

    @madhur-ob
    madhur-ob committed May 23, 2024
    Configuration menu
    Copy the full SHA
    d661bbc View commit details
    Browse the repository at this point in the history