[argo] Add k8s labels to tempalte.metadata instead of spec.podMetadata #1622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Argo does not propagate the spec.podLabels to the pods. Only the sections under templates from the WorkflowTemplate are propagated to the Workflow and the pods. Their docs are misleading.
Here are related argo issues,
workflowTemplateRef
argoproj/argo-workflows#7091Particularly, this comment is helpful in demystifying some confusion of the argo terminology
Testing
I tested against my argo installation. I did not see my custom labels before the change and I saw the labels applied after the change. I used
METAFLOW_KUBERNETES_LABELS
property in the~/.metaflowconfig/config.json
file.