Adding API routes for various resource cluster related actions #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundargates
requested review from
Andyz26,
calvin681,
codyrioux,
fdc-ntflx,
hmitnflx,
jeffchao,
liuml07,
markcho,
nickmahilani and
piygoyal
as code owners
liuml07
approved these changes
Apr 20, 2022
Andyz26
approved these changes
Apr 20, 2022
| * Defines the following end points: | ||
| * /api/v1/resourceClusters/list (GET) | ||
| * | ||
| * /api/v1/resourceClusters/{}/getResourceOverview (GET) |
Collaborator
There was a problem hiding this comment.
"Get" is already implicit from http action.
| */ | ||
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| public class ResourceClustersReadRoute extends BaseRoute { |
Collaborator
There was a problem hiding this comment.
Maybe add some test coverage for these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md