Skip to content

Fixing flaky tests #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sundargates merged 5 commits into from
Apr 14, 2022
Merged

Fixing flaky tests #174

sundargates merged 5 commits into from
Apr 14, 2022

Conversation

@sundargates
Copy link
Contributor

@sundargates sundargates commented Apr 13, 2022 •
edited
Loading

Context

Should fix the flakiness affecting multiple builds such as #171

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

Unit Test Results

107 files   -     1  107 suites   - 1   5m 26s ⏱️ -2s
471 tests  - 116  452 ✔️  - 116  19 💤 ±0  0 ❌ ±0 

Results for commit 3f7e9de. ± Comparison against base commit 1776919.

This pull request removes 123 and adds 7 tests. Note that renamed tests count towards both. 
io.mantisrx.master.api.akka.route.LeaderRedirectionRouteTest ‑ testMasterInfoAPIWhenNotLeader
io.mantisrx.master.api.akka.route.v0.AgentClusterRouteTest ‑ testGetActiveAgentClusters
io.mantisrx.master.api.akka.route.v0.AgentClusterRouteTest ‑ testGetAgentClustersList
io.mantisrx.master.api.akka.route.v0.AgentClusterRouteTest ‑ testGetJobsOnVMs
io.mantisrx.master.api.akka.route.v0.AgentClusterRouteTest ‑ testSetActiveVMs
io.mantisrx.master.api.akka.route.v0.JobClusterRouteTest ‑ cleanupExistingJobs
io.mantisrx.master.api.akka.route.v0.JobClusterRouteTest ‑ testDuplicateJobClusterCreateFails
io.mantisrx.master.api.akka.route.v0.JobClusterRouteTest ‑ testJobClusterCreate
io.mantisrx.master.api.akka.route.v0.JobClusterRouteTest ‑ testJobClusterDelete
io.mantisrx.master.api.akka.route.v0.JobClusterRouteTest ‑ testJobClusterDisable
…

io.mantisrx.master.api.akka.route.v0.AgentClusterRouteTest ‑ testIt
io.mantisrx.master.api.akka.route.v0.JobClusterRouteTest ‑ testIt
io.mantisrx.master.api.akka.route.v1.AgentClustersRouteTest ‑ testIt
io.mantisrx.master.api.akka.route.v1.JobClustersRouteTest ‑ testIt
io.mantisrx.master.api.akka.route.v1.JobDiscoveryStreamRouteTest ‑ testJobDiscoveryStreamForNonExistentJob
io.mantisrx.master.api.akka.route.v1.JobDiscoveryStreamRouteTest ‑ testLastSubmittedJobIdStreamForNonExistentJob
io.mantisrx.master.api.akka.route.v1.JobsRouteTest ‑ testIt

♻️ This comment has been updated with latest results.

@hmitnflx
Copy link
Contributor

hmitnflx commented Apr 13, 2022

This is a really nice change! Kudos!

sundargates
sundargates commented Apr 13, 2022
View reviewed changes
...mantis-control-plane-server/src/main/java/io/mantisrx/master/jobcluster/JobClusterActor.java
sender.tell(new JobClusterProto.InitializeJobClusterResponse(initReq.requestId,
SERVER_ERROR, String.format("JobCluster %s not created due to %s",
initReq.jobClusterDefinition.getName(), e.getMessage()),
initReq.jobClusterDefinition.getName(), Throwables.getStackTraceAsString(e)),
Copy link
Contributor Author

@sundargates sundargates Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codyrioux Is this okay?

sundargates
sundargates commented Apr 13, 2022
View reviewed changes
...l-plane-server/src/test/java/io/mantisrx/master/api/akka/route/v0/AgentClusterRouteTest.java Outdated


@Test(dependsOnMethods = {"testSetActiveVMs"})
// (dependsOnMethods = {"testSetActiveVMs"})
Copy link
Contributor Author

@sundargates sundargates Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented this out primarily because I want to see if this feature is supported in Junit5.

@sundargates sundargates merged commit b0f9e60 into Netflix:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyrioux codyrioux Awaiting requested review from codyrioux

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@markcho markcho Awaiting requested review from markcho

@liuml07 liuml07 Awaiting requested review from liuml07

1 more reviewer

@hmitnflx hmitnflx hmitnflx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sundargates @hmitnflx