Skip to content

Conversation

@hmitnflx
Copy link
Contributor

Context

Currently, we depend on the local copy of jar (subproject) for mantis-shaded dependency. However, this leads to problems with IntelliJ where you have to manually add the mantis-shaded subproject as an explicit library dependency at the root OR deal with a bunch of redlines for these shaded components.

We tried a bunch of alternatives like publishing to local maven or including these shaded dependencies at the terminal level (leaf projects) and they open-up more issues. We decided to host mantis-shaded in a separate repo but we think this could be a better alternative

Checklist

  • [*] ./gradlew build compiles code correctly
  • [*] Added new tests where applicable
  • [*] ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • [*] Added copyright headers for new files from CONTRIBUTING.md

Copy link
Contributor

@sundargates sundargates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Thanks for fixing this and coming up with the idea! I cannot wait to get this merged.

build.gradle Outdated
if (!"mantis-shaded".equals(project.name)) {
exclude group: 'com.fasterxml'
exclude group: 'io.vavr.jackson.datatype'
exclude group: 'com.google'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want put the module name too?

Copy link
Contributor

@sundargates sundargates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome change!

@hmitnflx hmitnflx merged commit 406298e into master Mar 22, 2022
@sundargates sundargates deleted the build branch March 26, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants