-
Notifications
You must be signed in to change notification settings - Fork 212
Depend on remote artifacts for mantis-shaded instead of local subproject #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...mantis-server-worker/src/main/java/io/mantisrx/server/worker/jobmaster/JobMasterService.java
Show resolved
Hide resolved
sundargates
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Thanks for fixing this and coming up with the idea! I cannot wait to get this merged.
build.gradle
Outdated
| if (!"mantis-shaded".equals(project.name)) { | ||
| exclude group: 'com.fasterxml' | ||
| exclude group: 'io.vavr.jackson.datatype' | ||
| exclude group: 'com.google' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want put the module name too?
sundargates
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome change!
Context
Currently, we depend on the local copy of jar (subproject) for mantis-shaded dependency. However, this leads to problems with IntelliJ where you have to manually add the mantis-shaded subproject as an explicit library dependency at the root OR deal with a bunch of redlines for these shaded components.
We tried a bunch of alternatives like publishing to local maven or including these shaded dependencies at the terminal level (leaf projects) and they open-up more issues. We decided to host mantis-shaded in a separate repo but we think this could be a better alternative
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md