RTDI-2167 source job has incorrect subscriptions #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmahilani
approved these changes
Mar 9, 2022
Contributor
There was a problem hiding this comment.
this can be logged at INFO to avoid triggering a downstream alert from our RADAR logging infra.
Contributor
There was a problem hiding this comment.
can add a metric to track rejections due to this
nickmahilani
reviewed
Mar 9, 2022
Contributor
There was a problem hiding this comment.
naming nit: sourceJobName -> targetJobCluster as the SSE sink could be on any job
Contributor
Author
There was a problem hiding this comment.
The first commit actually uses targetJob but we had a bit of a debate in a Slack thread because Raven currently uses sourceJobName.
Collaborator
There was a problem hiding this comment.
No strong feeling either way. Just pointing out sourceJobName is what's used in raven's TargetInfo json.
codyrioux
force-pushed
the
2167-source-job-has-incorrect-subscriptions
branch
from
1a309a4 to
1f24186
Compare
codyrioux
requested review from
Andyz26,
jeffchao,
piygoyal and
sundargates
as code owners
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have detected an issue internally that occurs with low probability. Connectors retrying an
IP:PORTcombination may connect to an unrelated job if that sameIP:PORTcombination is reused in a time frame less than the the client's expiration period. To address this we'll be making connection intentions explicit by passing asourceJobNameparameter when making a connection.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md