Repository navigation
docs: fix dead badges and stale install instructions in README - #870
Open
mmilanovic4 wants to merge 1 commit into
Open
mmilanovic4 wants to merge 1 commit into
mmilanovic4 wants to merge 1 commit into
Conversation
travis-ci.com 404s for this repo and Bintray was shut down in 2021, so both badges render nothing. Point them at the nebula-ci.yml workflow and Maven Central instead. The install snippets in the same section had also drifted: 5.1.3 against a latest tag of v7.15.3, and a `compile` configuration that Gradle 7 removed. Fix Netflix#718
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #718.
Badges
Both badges reported in #718 are dead:
travis-ci.com/Netflix/hollow, which 404s. CI forthis repo runs through
.github/workflows/nebula-ci.yml, so the badge nowpoints there.
api.bintray.com. Bintray was shut down in 2021 andthe image no longer renders. Replaced with a Maven Central badge, which tracks
the published version on its own rather than needing a bump.
Install instructions
The surrounding text in the same section had drifted as well, so this includes
the smallest set of fixes that makes it correct:
5.1.3. The most recent releasetag in this repo is
v7.15.3, so I used that.compile, which Gradle 7 removed. Copying it into acurrent build fails, so it is now
implementation.Testing
Documentation only.