This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Fixes get_signal_engagement_by_name call in signals create module and several type annotations #5292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
commented
Oct 4, 2024
wssheldon
reviewed
Oct 4, 2024
wssheldon
approved these changes
Oct 4, 2024
mvilanova
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve type annotations and import organization. The most important changes involve updating function signatures to include type annotations and reorganizing imports for better readability.
Type Annotation Improvements:
src/dispatch/data/alert/service.py: Updated theget_by_name_or_raisefunction to include type annotations for thealert_inparameter.src/dispatch/organization/service.py: Updated multiple functions (get_by_name_or_raise,get_by_slug_or_raise,get_by_name_or_default) to include type annotations for theorganization_inparameter. [1] [2] [3]src/dispatch/project/service.py: Updated theget_by_name_or_raiseandget_by_name_or_defaultfunctions to include type annotations for theproject_inparameter. [1] [2]src/dispatch/service/service.py: Updated theget_by_name_or_raisefunction to include type annotations for theservice_inparameter.src/dispatch/signal/service.py: Updated multiple functions (get_signal_engagement_by_name_or_raise,get_signal_filter_by_name_or_raise) to include type annotations for thesignal_engagement_inandsignal_filter_inparameters respectively. [1] [2]Import Organization:
src/dispatch/data/alert/service.py: Reorganized imports to group similar imports together and removed redundant imports.src/dispatch/project/service.py: Reorganized imports to group similar imports together and removed redundant imports.src/dispatch/service/service.py: Reorganized imports to group similar imports together and removed redundant imports.src/dispatch/tag/service.py: Reorganized imports to group similar imports together and removed redundant imports.src/dispatch/tag_type/service.py: Reorganized imports to group similar imports together and removed redundant imports.src/dispatch/workflow/service.py: Reorganized imports to group similar imports together and removed redundant imports. [1] [2]