Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@whitdog47
Copy link
Contributor

This PR allows for an alternative folder structure when creating the incident storage, with options defined per project. The following options are added:
(1) Allows for setting the names of the two storage folders created (current defaults are "Logs" and "Screengrabs")
(2) Allows the main storage folder of the incident and review documents to be put under one of these folders
(3) Allows the title of the storage folder to be named with the name of the incident instead of the incident number
(4) Allows for the main storage folder location to be defined by the uri of the tag set when the incident is created
(5) Allows the incident and review document templates to contain tag type placeholders in the form {{tag_tagType}}

image

@whitdog47 whitdog47 added the enhancement New feature or request label Jul 2, 2024
@whitdog47 whitdog47 self-assigned this Jul 2, 2024
@whitdog47 whitdog47 marked this pull request as ready for review July 11, 2024 22:02
@whitdog47 whitdog47 requested a review from metroid-samus July 11, 2024 22:02
@wssheldon
Copy link
Contributor

He wont stop shipping!!!

@metroid-samus
Copy link
Contributor

metroid-samus commented Jul 17, 2024

After enabling the alternative folder structure, I discovered the following:

Create a new Incident without tags:

  • In the incident's Resources tab, the Storage link takes the user to the Primary folder. I was expecting it to take me to the parent folder that shares the name of the incident. If this is the expected behavior, I would recommend also adding the Secondary folder to the Resources tab.
  • The incident document is created, but it is not listed under the Resources tab. Never mind. This eventually populated.

Create a new Incident with tags:

  • It is not intuitive that the tag's URI should be a Google Drive folder ID and not a URL. Maybe this can be relabeled as resource_id?

@whitdog47 whitdog47 merged commit 637dc14 into master Jul 21, 2024
@whitdog47 whitdog47 deleted the enhancement/alt-folder-structure branch July 21, 2024 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants