This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Adds a new project settings section for managing search filters #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
commented
May 17, 2023
Contributor
|
Do we want to add more permissions to these? I think they drive quite a lot of functionality, creating new filters is probably fine. But deleting/modifying/disabling existing filters is likely to be problematic. |
Contributor
Author
|
mvilanova
force-pushed
the
enhancement/search-filter-ui
branch
from
6f1b23e to
0d44e2f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new section to the project settings for viewing and deleting search filters. Options for creating new and editing existing filters will be added in the future. We only allow users with admin, manager, and owner role to delete filters.