Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Adds 250/minute rate limit to SignalInstance POST API endpoint using slowapi #3338

Merged
wssheldon merged 4 commits into from
May 5, 2023
Merged

Adds 250/minute rate limit to SignalInstance POST API endpoint using slowapi #3338

wssheldon merged 4 commits into from
May 5, 2023

Conversation

@wssheldon
Copy link
Contributor

@wssheldon wssheldon commented May 2, 2023

No description provided.

@wssheldon wssheldon added the enhancement New feature or request label May 2, 2023
@wssheldon wssheldon requested a review from mvilanova May 2, 2023 17:42
mvilanova
mvilanova approved these changes May 2, 2023
View reviewed changes
@wssheldon
Copy link
Contributor Author

wssheldon commented May 5, 2023 

DEBUG:http://localhost:8080 "POST /api/v1/default/signals/instances HTTP/1.1" 429 28:/Users/wshel/.pyenv/versions/3.11.2/envs/dispatch-prod/lib/python3.11/site-packages/urllib3/connectionpool.py:_make_request:456
INFO:Response: {'detail': '10 per 1 minute'}:/Users/wshel/Projects/dispatch/src/dispatch/cli.py:_send_signal_instance:749
ERROR:Unable to send finding. Reason: 429 Client Error: Too Many Requests for url: http://localhost:8080/api/v1/default/signals/instances Response: N/A:/Users/wshel/Projects/dispatch/src/dispatch/cli.py:_send_signal_instance:758

@wssheldon wssheldon merged commit 39f1211 into master May 5, 2023
@wssheldon wssheldon deleted the enhancement/instance-ratelimit branch May 5, 2023 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mvilanova mvilanova mvilanova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wssheldon @mvilanova