This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Fixes breaking changes impacting incident ban threads feature #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
commented
Apr 28, 2023
mvilanova
commented
Apr 28, 2023
mvilanova
commented
Apr 28, 2023
Contributor
|
I tested with threads banned and did not get the message within a Case thread. |
wssheldon
reviewed
Apr 28, 2023
wssheldon
approved these changes
Apr 28, 2023
Contributor
wssheldon
left a comment
wssheldon
left a comment
There was a problem hiding this comment.
Everything looks good on the Case side. I tested:
- Case creation
- Main case message updates (edit, resolve, etc)
- Signal deduplication thread message updates
- Engagement thread messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes breaking changes (here and here) introduced in this PR.