This repository was archived by the owner on Sep 3, 2025. It is now read-only.
CLI drop database modified to address in case the database doesn't exist #3064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevgliss
approved these changes
Mar 7, 2023
Contributor
kevgliss
left a comment
kevgliss
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
Contributor
Author
Thanks for letting me contribute |
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…ist (Netflix#3064) Co-authored-by: Shefeek Najeeb <shefeek@kmmrce.com>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…ist (Netflix#3064) (#49) Co-authored-by: Shefeek N <30828752+nshefeek@users.noreply.github.com> Co-authored-by: Shefeek Najeeb <shefeek@kmmrce.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run
dispatch database dropwhen the database is not existing, it results insqlalchemy.exc.ProgrammingError. This is just a minor fix to give a better CLI experience.