This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Add a new slack slash command /dispatch-list-signals and allow creation of Snooze filter w/ MFA
#3050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
commented
Mar 3, 2023
| else: | ||
| raise e from None | ||
|
|
||
| if response.get("result") == "allow": |
Contributor
Author
There was a problem hiding this comment.
We haven't abstracted Auth response across all base MFA plugin providers
Contributor
Author
|
Need to update documentation w/ new command |
wssheldon
commented
Mar 3, 2023
wssheldon
commented
Mar 3, 2023
wssheldon
commented
Mar 3, 2023
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…tion of Snooze filter w/ MFA (Netflix#3050) * Initial pass at adding a /list-signals command and snooze w/ MFA * Initial pass at adding a /list-signals command and snooze w/ MFA * remove print statement * add docs * add docstrings, missing types * Add a preview intermediary modal * calculate relative date on signal filter create * remove signal service imports * black formatting * add casetype model to signal service * remove datetime unused import
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…tion of Snooze filter w/ MFA (Netflix#3050) (#34) * Initial pass at adding a /list-signals command and snooze w/ MFA * Initial pass at adding a /list-signals command and snooze w/ MFA * remove print statement * add docs * add docstrings, missing types * Add a preview intermediary modal * calculate relative date on signal filter create * remove signal service imports * black formatting * add casetype model to signal service * remove datetime unused import Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.