feature: Local Time Scalar

[Ancient-Dragon]

Please read our contributor guide before
creating an issue. Also consider discussing your idea on
the discussion forum first.

Describe the Feature Request

Supporting a local time scalar, this would allow the user of the library to have a java local time as an input argument.

Describe Preferred Solution

I guess there could be two ways this could be implemented:

• DGS could use latest version of graphql-java-extended-scalars - 2022-02-25T03-14-46-8c3b172
• DGS could implement its own version of a local time scalar

Describe Alternatives

We could implement a custom scalar, but we felt that this could be widely used by other people.

[srinivasankavitha]

Thanks, seems reasonable to update to the latest version of extended-scalars. Will do that for the next release (mostly next week).

…

On Thu, Mar 31, 2022 at 3:18 AM Ancient-Dragon ***@***.***> wrote: Please read our contributor guide <https://github.com/Netflix/dgs-framework/blob/master/CONTRIBUTING.md> before creating an issue. Also consider discussing your idea on the discussion forum <https://github.com/Netflix/dgs-framework/discussions> first. Describe the Feature Request Supporting a local time scalar, this would allow the user of the library to have a java local time as an input argument. Describe Preferred Solution I guess there could be two ways this could be implemented: - DGS could use latest version of graphql-java-extended-scalars <https://github.com/graphql-java/graphql-java-extended-scalars> - 2022-02-25T03-14-46-8c3b172 <https://mvnrepository.com/artifact/com.graphql-java/graphql-java-extended-scalars/2022-02-25T03-14-46-8c3b172> - DGS could implement its own version of a local time scalar Describe Alternatives We could implement a custom scalar, but we felt that this could be widely used by other people. — Reply to this email directly, view it on GitHub <#953>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ5JPXO4BNTNDSIOOSS66CDVCV3VVANCNFSM5SE4AXGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[setchy]

As far as I'm aware, DGS already uses the latest published version of graphql-java-extended-scalars (v17.0) that isn't a nightly snapshot, but in 17.0 LocalTime isn't part of their ExtendedScalars entry point, which I'd be guessing is why it wasn't referenced in

dgs-framework/graphql-dgs-extended-scalars/src/main/kotlin/com/netflix/graphql/dgs/autoconfig/DgsExtendedScalarsAutoConfiguration.kt

Line 48 in 5bfe8dd

open fun timesExtendedScalarsRegistrar(): ExtendedScalarRegistrar {

I've raised a simple PR graphql-java/graphql-java-extended-scalars#57 to get the ball rolling on a new non-snapshot version that will also include a proper ExtendedScalars.LocalTime entry point

[joshvince]

👋 hey is there any reasonable timeline for when this might form part of the graphql-dgs-extended-scalars library? We're looking at the same thing (potentially implementing our own LocalTimeScalar) but don't want to if this is going to appear soon. Thank you for all your work on DGS!

[setchy]

@Ancient-Dragon @joshvince - released in v4.10.0