Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Update WorkflowExecutor.java #3875

Closed
wants to merge 6 commits into from
Closed

Update WorkflowExecutor.java #3875

wants to merge 6 commits into from

Conversation

youngledo
Copy link
Contributor

@youngledo youngledo commented Dec 1, 2023

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

The business requires "workflowId" to obtain the runtime process.

@manan164
Copy link
Contributor

manan164 commented Dec 4, 2023

Hi @youngledo , Workflow already contains workflowId. Is there a reason to change the behaviour to just return workflowId and not workflow model?

@youngledo
Copy link
Contributor Author

youngledo commented Dec 5, 2023

Hi @youngledo , Workflow already contains workflowId. Is there a reason to change the behaviour to just return workflowId and not workflow model?

Sorry, I didn't make it clear.

image The "workflowId" in this method is only cached in "runningWorkflowFutures" and cannot be obtained by external sources. image The workflow model object results are returned in the scheduling thread pool and cannot be obtained in real time.

@youngledo youngledo closed this by deleting the head repository May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants