This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Preserve task domains for tasks inside do_while loop #1939
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On every iteration, apply task domains as set in the workflow execution. This feature was missing and made do wile behave incorrectly when using task domains (since the domains were reset for tasks inside the loop) Signed-off-by: Maros Marsalek <mmarsalek@frinx.io>
marosmars
force-pushed
the
dowhile_taskdomains
branch
from
f921faa
to
f25c196
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1939 +/- ##
============================================
+ Coverage 65.57% 65.59% +0.02%
- Complexity 3928 3930 +2
============================================
Files 301 301
Lines 18527 18528 +1
Branches 1685 1685
============================================
+ Hits 12149 12154 +5
+ Misses 5537 5534 -3
+ Partials 841 840 -1
Continue to review full report at Codecov.
|
|
Hey @apanicker-nflx , this is a small improvement (single line changed) to the do while task, including unit tests. |
apanicker-nflx
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every iteration, apply task domains as set in the workflow execution.
This feature was missing and made do wile behave incorrectly when using
task domains (since the domains were reset for tasks inside the loop).
Signed-off-by: Maros Marsalek mmarsalek@frinx.io