This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
In processAllUnacks, change it so only the unacks from the past get reset #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me vote "Merge" on this one... |
|
Please fix the build failure : |
added 4 commits
September 24, 2020 14:31
Codecov Report
@@ Coverage Diff @@
## dev #1875 +/- ##
============================================
+ Coverage 64.91% 65.00% +0.08%
- Complexity 3866 3888 +22
============================================
Files 298 299 +1
Lines 18387 18451 +64
Branches 1674 1684 +10
============================================
+ Hits 11936 11994 +58
- Misses 5623 5624 +1
- Partials 828 833 +5
Continue to review full report at Codecov.
|
added 10 commits
September 24, 2020 15:38
|
@apanicker-nflx I fixed the build error but I did it by converting the test case so that it would work with the new code. I am not completely sure whether the old test case was constructed to conform to the old code or if it was a legitimate test case that I should have left alone. I would like someone else to review it if possible. |
|
@mactaggart @mashurex Could you please help with reviewing this pull request? Thanks |
mashurex
approved these changes
Oct 2, 2020
mactaggart
approved these changes
Oct 4, 2020
TwoUnderscorez
pushed a commit
to TwoUnderscorez/conductor
that referenced
this pull request
Jul 23, 2021
…eset (Netflix#1875) * only reset unacks from the past * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code * fix the test cases so that it matches the change to the code Co-authored-by: u447 <rick.fishman@bcbsfl.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for Issue #1859. Tasks that were popped had their popped status set to false before they were acked so a future poll could get the same task. This PR only resets the popped flag for tasks that were popped in the past by a minute, not in the future by a minute.