Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Ignore queue exceptions in terminate workflow logic. #1863

Merged

Conversation

kishorebanala
Copy link
Contributor

@kishorebanala kishorebanala commented Sep 11, 2020

Failure to remove from queue during terminate wouldn't cause any side effects, and can be cleaned up in subsequent operations. However, queue exceptions are catched as blockers in terminateWorkflow logic, ignoring subsequent operations in terminate logic like canceling the tasks, starting the failure workflow etc.

This PR will catch and log the queue remove exceptions, and continue with terminate workflow logic.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #1863 into dev will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1863      +/-   ##
============================================
+ Coverage     64.97%   65.00%   +0.02%     
+ Complexity     3871     3867       -4     
============================================
  Files           298      298              
  Lines         18383    18386       +3     
  Branches       1674     1674              
============================================
+ Hits          11945    11951       +6     
+ Misses         5610     5607       -3     
  Partials        828      828              
Impacted Files Coverage Δ Complexity Δ
...lix/conductor/core/execution/WorkflowExecutor.java 77.86% <83.33%> (+0.08%) 180.00 <1.00> (ø)
...ix/conductor/dao/postgres/PostgresMetadataDAO.java 77.00% <0.00%> (-5.35%) 66.00% <0.00%> (-3.00%)
.../conductor/dao/cassandra/CassandraMetadataDAO.java 58.03% <0.00%> (+2.59%) 24.00% <0.00%> (-1.00%) ⬆️
...ductor/dao/cassandra/CassandraEventHandlerDAO.java 76.31% <0.00%> (+10.52%) 15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289ca1c...914f9b1. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4520

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 69.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 2 55.44%
postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresMetadataDAO.java 11 80.75%
Totals Coverage Status
Change from base Build 4501: -0.07%
Covered Lines: 12769
Relevant Lines: 18386

💛 - Coveralls

@kishorebanala kishorebanala merged commit db2d1cb into dev Sep 14, 2020
@kishorebanala kishorebanala deleted the bugfix/queue_exceptions_during_terminate_workflow branch September 14, 2020 23:29
marosmars pushed a commit to marosmars/conductor that referenced this pull request Oct 13, 2020
TwoUnderscorez pushed a commit to TwoUnderscorez/conductor that referenced this pull request Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants