Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Add ability to configure the connection request timeout for Elasticsearch rest client #1847

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

mdepak
Copy link
Contributor

@mdepak mdepak commented Aug 28, 2020

By default, the connection request timeout is interpreted from the system default. Under high throughput scenarios, elasticsearch client timeout when getting the connection from the HTTP rest-client library.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1847 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1847      +/-   ##
============================================
+ Coverage     64.87%   64.90%   +0.02%     
- Complexity     3841     3867      +26     
============================================
  Files           295      298       +3     
  Lines         18206    18383     +177     
  Branches       1658     1674      +16     
============================================
+ Hits          11812    11932     +120     
- Misses         5576     5623      +47     
- Partials        818      828      +10     
Impacted Files Coverage Δ Complexity Δ
...ductor/dao/cassandra/CassandraEventHandlerDAO.java 65.78% <0.00%> (-10.53%) 15.00% <0.00%> (ø%)
...ix/conductor/dao/postgres/PostgresMetadataDAO.java 77.00% <0.00%> (-4.67%) 66.00% <0.00%> (ø%)
.../conductor/dao/cassandra/CassandraMetadataDAO.java 53.88% <0.00%> (-4.15%) 24.00% <0.00%> (ø%)
...tflix/conductor/dao/postgres/PostgresQueueDAO.java 87.60% <0.00%> (-3.31%) 51.00% <0.00%> (-1.00%)
...tor/core/config/SystemPropertiesConfiguration.java 62.50% <0.00%> (-1.00%) 25.00% <0.00%> (ø%)
...ductor/validations/WorkflowTaskTypeConstraint.java 89.40% <0.00%> (-0.31%) 0.00% <0.00%> (ø%)
...onductor/common/metadata/workflow/WorkflowDef.java 87.15% <0.00%> (-0.23%) 47.00% <0.00%> (+2.00%) ⬇️
...om/netflix/conductor/grpc/AbstractProtoMapper.java 41.85% <0.00%> (-0.18%) 71.00% <0.00%> (ø%)
.../com/netflix/conductor/core/config/CoreModule.java 100.00% <0.00%> (ø) 23.00% <0.00%> (+2.00%)
...m/netflix/conductor/core/config/Configuration.java 70.27% <0.00%> (ø) 21.00% <0.00%> (ø%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cbfa2...580b56a. Read the comment docs.

@kishorebanala
Copy link
Contributor

@mdepak +1. Can you also add this to es6-persistence module to keep both the modules consistent please?

@mdepak
Copy link
Contributor Author

mdepak commented Sep 3, 2020

@kishorebanala Added the config to es6-persistence module as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants