-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javanica iss 907 #945
Merged
Merged
Javanica iss 907 #945
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9aa978d
iss-907: adopt code for classes compiled with ajc.
dmgcodevil 2779b78
iss-907: added support for simple command after ajc compilation
dmgcodevil 08d1007
iss-907: finish adopting CommandTest for ajc
dmgcodevil ad9cedc
iss-907: added ajc support simple fallback
dmgcodevil 5938e85
iss-907: implemented fallback and cache
dmgcodevil 3579733
iss-907: added test for ajc: error, props, oversvable
dmgcodevil 958ec5d
iss-907: clean up
dmgcodevil 1518175
iss-907: added sep jar with aspects compiled with ajc
dmgcodevil bd7781e
iss-907 fix dependencies
dmgcodevil 4a4a41f
iss-907: revert modified files
dmgcodevil d025970
Merge branch 'master' of https://github.com/Netflix/Hystrix into java…
dmgcodevil ff9814c
Merge branch 'master' of https://github.com/Netflix/Hystrix into java…
dmgcodevil a70456e
iss-907: set version for hystrix-javanica-ctw
dmgcodevil 87e7f5a
Update README.md
dmgcodevil 393ae5a
Update README.md
dmgcodevil fe366ac
Update README.md
dmgcodevil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
org.gradle.java.home=c:/Program Files/Java/jdk1.7.0_79 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...a/src/ajcTest/java/com/netflix/hystrix/contrib/javanica/test/aspectj/cache/CacheTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.cache; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.cache.BasicCacheTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class CacheTest extends BasicCacheTest { | ||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
UserService userService = new UserService(); | ||
userService.init(); | ||
return userService; | ||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
...cTest/java/com/netflix/hystrix/contrib/javanica/test/aspectj/collapser/CollapserTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.collapser; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.collapser.BasicCollapserTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class CollapserTest extends BasicCollapserTest { | ||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
} |
23 changes: 23 additions & 0 deletions
23
...c/ajcTest/java/com/netflix/hystrix/contrib/javanica/test/aspectj/command/CommandTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.command; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.command.BasicCommandTest; | ||
import org.junit.BeforeClass; | ||
|
||
|
||
public class CommandTest extends BasicCommandTest { | ||
|
||
@BeforeClass | ||
public static void setUpEnv(){ | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
|
||
@Override | ||
protected AdvancedUserService createAdvancedUserServiceService() { | ||
return new AdvancedUserService(); | ||
} | ||
} |
20 changes: 20 additions & 0 deletions
20
...ystrix/contrib/javanica/test/aspectj/configuration/collapser/CollapserPropertiesTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.configuration.collapser; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.configuration.collapser.BasicCollapserPropertiesTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class CollapserPropertiesTest extends BasicCollapserPropertiesTest { | ||
|
||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
} |
20 changes: 20 additions & 0 deletions
20
...ix/hystrix/contrib/javanica/test/aspectj/configuration/command/CommandPropertiesTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.configuration.command; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.configuration.command.BasicCommandPropertiesTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class CommandPropertiesTest extends BasicCommandPropertiesTest { | ||
|
||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
...st/java/com/netflix/hystrix/contrib/javanica/test/aspectj/error/ErrorPropagationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.error; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.error.BasicErrorPropagationTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class ErrorPropagationTest extends BasicErrorPropagationTest { | ||
|
||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
|
||
} |
20 changes: 20 additions & 0 deletions
20
.../java/com/netflix/hystrix/contrib/javanica/test/aspectj/fallback/CommandFallbackTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.fallback; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.fallback.BasicCommandFallbackTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class CommandFallbackTest extends BasicCommandFallbackTest { | ||
|
||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
} |
20 changes: 20 additions & 0 deletions
20
...est/java/com/netflix/hystrix/contrib/javanica/test/aspectj/observable/ObservableTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.netflix.hystrix.contrib.javanica.test.aspectj.observable; | ||
|
||
import com.netflix.hystrix.contrib.javanica.test.common.observable.BasicObservableTest; | ||
import org.junit.BeforeClass; | ||
|
||
/** | ||
* Created by dmgcodevil | ||
*/ | ||
public class ObservableTest extends BasicObservableTest { | ||
|
||
@BeforeClass | ||
public static void setUpEnv() { | ||
System.setProperty("weavingMode", "compile"); | ||
} | ||
|
||
@Override | ||
protected UserService createUserService() { | ||
return new UserService(); | ||
} | ||
} |
Empty file.
10 changes: 10 additions & 0 deletions
10
hystrix-contrib/hystrix-javanica/src/ajcTest/resources/log4j.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Define the root logger with appender console | ||
log4j.rootLogger = ERROR, CONSOLE | ||
|
||
# Define the console appender | ||
log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender | ||
log4j.appender.CONSOLE.File=${log}/log.out | ||
|
||
# Define the layout for console appender | ||
log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout | ||
log4j.appender.CONSOLE.layout.conversionPattern=%m%n |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattrjacobs I added this task that creates jar with aspects compiled using ajc, so now build task results to two jars:
hystrix-javanica.jar
hystrix-javanica-ctw.jar
Should we change something else to publish both artifacts correctly ?