Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed possible memory leak in ScheduledThreadPoolExecutor (HystrixTimer.java) #1976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jagden
Copy link

@Jagden Jagden commented Dec 1, 2019

Found what seems to be a possible memory leak inside HystrixTimer.java caused by cancel operations called on tasks inside a ScheduledThreadPoolExecutor.
The fix helped us and solved the leakage.
Tasks that were canceled due to timeouts were not removed from the scheduler queues unless setRemoveOnCancelPolicy(true) was called on that scheduler on initialization.

@tweimer
Copy link

tweimer commented Sep 6, 2020

Fixes #1998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants