Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iss:1387: Performance improvement in EnvUtils. Read "weavingMode" system property only one time. #1393

Merged
merged 1 commit into from
Oct 19, 2016
Merged

iss:1387: Performance improvement in EnvUtils. Read "weavingMode" system property only one time. #1393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...b/hystrix-javanica/src/main/java/com/netflix/hystrix/contrib/javanica/utils/EnvUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,22 @@
* Created by dmgcodevil
*/
public final class EnvUtils {

private static final String WEAVING_MODE;

static {
WEAVING_MODE = System.getProperty("weavingMode", WeavingMode.RUNTIME.name()).toUpperCase();
}

private EnvUtils(){

}

public static WeavingMode getWeavingMode() {
String wavingModeParam = System.getProperty("weavingMode", WeavingMode.RUNTIME.name()).toUpperCase();
try {
return WeavingMode.valueOf(wavingModeParam);
return WeavingMode.valueOf(EnvUtils.WEAVING_MODE);
} catch (IllegalArgumentException e) {
throw new IllegalArgumentException("wrong 'weavingMode' property, supported: " + Arrays.toString(WeavingMode.values()) + ", actual = " + wavingModeParam, e);
throw new IllegalArgumentException("wrong 'weavingMode' property, supported: " + Arrays.toString(WeavingMode.values()) + ", actual = " + EnvUtils.WEAVING_MODE, e);
}
}

Expand Down