onRunSuccess/onThreadComplete hooks called in timeout flow #510
Milestone
Comments
|
I think it should call eventually whenever it does complete. A thread always ends (unless it's an infinite loop). It is clearer for it to eventually be called than to have cases where it only starts but never "ends". Also I don't want to break 1.3 behavior. |
|
Yeah, that's the way I was leaning, but didn't want to bias your response :) This will be a change in master only then. I'll also add some Javadoc to clarify this case, as it's not obvious. |
mattrjacobs
pushed a commit
to mattrjacobs/Hystrix
that referenced
this issue
Jan 14, 2015
…cutes, onRunSuccess and onThreadCompelte hooks get invoked even if calling thread times out.
mattrjacobs
added a commit
that referenced
this issue
Jan 14, 2015
Added Javadoc after clarifying #510. When a Hystrix thread executes,
|
Added Javadoc in #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In 1.3.x, under thread isolation, when a HystrixCommand times out, the
onRunSuccess/onThreadCompletehooks are invoked by the Hystrix thread eventually, even if the calling thread has already moved through the fallback flow.In master/1.4, only the
onThreadCompletehook is invoked (eventually)./cc @benjchristensen, @KoltonAndrus What should the semantics be? I'd like to decide that and then enforce it in both 1.3.x and master
The text was updated successfully, but these errors were encountered: