This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Synchronization #162
Open
Synchronization #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjwood
commented
Sep 19, 2017
| int waitingFor = 2; | ||
| while (waitingFor > 0) { | ||
| final Map<String, Integer> map = scaleupActionsQ.poll(coolDownSecs, TimeUnit.SECONDS); | ||
| Assert.assertNotNull(map); |
Author
There was a problem hiding this comment.
I thought that this needed adjusting but it looks like this assertion occasionally fails on master too.
aaronjwood
force-pushed
the
synchronization
branch
from
5638326 to
2f9ca87
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was synchronization being done around a
ConcurrentMapwhich would incur a performance hit. At first I thought this was maybe to make theget()+put()operations atomic but I only see one place where the map inside of the map (the value) is touched:Map existingTriggerMap = map.putIfAbsent(group, subMap);.The other half of this patch addresses some inconsistent synchronization where some methods were synchronized while others were not. It looked like this would potentially cause the methods to work with inconsistent state.