Feat/issues 209 #12
Open
Feat/issues 209 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninja: fix NPE disable ephemeral reads
don't load range commands that are redundant, and load least possible use MISC verb handler for maintenance tasks
…hutdown until after MS. Wake up segment prepared after shutting down allocator, as no new segments will ever be allocated. Shut down flusher slightly differently: we do not signal from fsync complete, since all blocks should have been fsynced by then, but we will add invariant check to notice runaway threads. Wait for quiescense Truncate blocking Wait for scheduler shutdown before shutting down command store Shut down accord after shutting down messaging Truncate caches before replay
split JournalKey in journal table so we can index it reorder journal fields so we can easily index on route (when present) use Message.expiresAtNanos for callback expiration do not notify slow for range barriers Accord: Do not contact faulty replicas, and promptly report slow replies for preaccept/read. Do not wait for stale or left nodes for durability.
…edup RoutingKey tableId; avoid calculating rejectsFastPath in more cases; delay retry of fetchMajorityDeps; fix SetShardDurable marking shards durable
… to ReconfigureAccordFastPath so the TCM logs/table gives the debug info needed
…low replies for preaccept/read. Do not wait for stale or left nodes for durability.
…plus minor performance improvements
update durability scheduling and majority deps fetching do not deserialize deps in CommandsForRangesLoader unless required AccordJournalPurger should use shouldCleanupPartial load historical transactions when loading topology
Patch by Ariel Weisberg; Reviewed by David Capwell for CASSANDRA-19955 Non-serial single partition reads on Accord Patch by Ariel Weisberg; Reviewed by Benedict Elliott Smith for CASSANDRA-19951
Fix NPE in MockJournal on null onFlush Fix SavedCommandTest. After the serialization change that serializes "changed" before "is null", null flag can no be written.
… to be empty, should also populate there as well patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-20017
patch by David Capwell; reviewed by Ariel Weisberg for CASSANDRA-20020
…fter reaching rf=3 patch by David Capwell; reviewed by Alex Petrov for CASSANDRA-19975
Patch by Alex Petrov; reviewed by Ariel Weisberg for CASSANDRA-20032 Accord Deps tests have incorrect range semantics patch by David Capwell; reviewed by Ariel Weisberg for CASSANDRA-20029
For correctness, the dependencies we adopt on joining a new topology must exclude the possibility of respondents accepting additional transactions with a lower TxnId, so proxying on the existing `ExclusiveSyncPoint` mechanisms is logical for the time-being. This patch removes the `FetchMajorityDeps` logic in favour of simply waiting for a suitable `ExclusiveSyncPoint` to be proposed. patch by Benedict, reviewed by Alex Petrov for CASSANDRA-20056
…pologyMixupTestBase patch by David Capwell; reviewed by Alex Petrov, David Capwell for CASSANDRA-20054
Patch by Ariel Weisberg; Reviewed by David Capwell for CASSANDRA-20060
…locks and performance issues patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-20065
Patch by Ariel Weisberg; Reviewed by Benedict Elliott Smith for CASSANDRA-19436
patch by Aleksey Yeschenko; reviewed by Benedict Elliott Smith and David Capwell for CASSANDRA-20062
Patch by Ariel Weisberg; Reviewed by Benedict Elliott Smith for CASSANDRA-19437
patch by Aleksey Yeschenko; reviewed by Benedict Elliott Smith for CASSANDRA-20062
Patch by Venkata Harikrishna Nukala; reviewed by Marcus Eriksson and Sam Tunnicliffe for CASSANDRA-18509
- cfk pruning+prebootstrap=invalid future dependency - exclude retired ranges when filtering RX stillTouches - propagate uses incorrect lowEpoch when fetch finds additional owned/touched ranges - node.withEpoch should callback with TopologyRetiredException, not throw - Recovery can race with durable-applied pruning; must not send durable unless latest ballot on apply - removeRedundantDependencies was not slicing pre-bootstrap range calculation to participating ranges - NPE in TopologyManager.atLeast caused by referencing an epoch that has been GC'd - use journal durableBeforePersister in burn test, not NOOP_PERSISTER - ServerUtils.cleanupDirectory use tryDeleteRecursive - FsyncRunnable shutdown - fix NPE in AccordJournalBurnTest patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20688
…s) to 4.1 and 5.0 patch by Ariel Weisberg; reviewed by Benedict Elliott Smith for CASSANDRA-20585
Patch by Ariel Weisberg and Yuqi Yan; Reviewed by Marcus Eriksson for CASSANDRA-20513 Co-authored-by: Yuqi Yan <yukei0509@gmail.com>
patch by Dmitry Konstantinov; reviewed by Michael Semb Wever, Stefan Miklosovic for CASSANDRA-20681
patch by Ling Mao; reviewed by Stefan Miklosovic, Maxim Muzafarov for CASSANDRA-20499 Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
…g BtiFormat Patch by marcuse; reviewed by Mick Semb Wever for CASSANDRA-18119
…ain compression level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira