Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ResourceChangeListeners #621

Closed
joerghoh opened this issue Dec 14, 2021 · 3 comments · Fixed by #625
Closed

Use ResourceChangeListeners #621

joerghoh opened this issue Dec 14, 2021 · 3 comments · Fixed by #625
Milestone

Comments

@joerghoh
Copy link

I found that biz.netcentric.cq.tools.actool.configuploadlistener.impl.UploadListenerServiceImpl$AcToolConfigUpdateListener is registered to listen for OSGI Resource Events.

This approach is deprecated by now, instead you should use the ResourceChangeListener approach, as indicated in the Sling documentation

@ghenzler
Copy link
Member

ghenzler commented Jan 14, 2022

@joerghoh we don't really recommend to use it (see https://github.com/Netcentric/accesscontroltool/blob/develop/docs/ApplyConfig.md#upload-listener-service, it's more there for historical reasons), but yes, it should be upgraded to use the ResourceChangeListener approach

@ghenzler ghenzler added this to the 3.0.5 milestone Jan 14, 2022
@royteeuwen
Copy link

@ghenzler It would be nice because the install hook way for local development polutes the configuration for the cloud deployment, forcing it to be put on mixed instead of container

@ghenzler
Copy link
Member

@royteeuwen The upload listener would not allow to restrict/allow access to product functionality in /libs and /apps, using a separate package for all yaml files with type mixed ala https://github.com/Netcentric/accesscontroltool/blob/develop/docs/Installation.md#declaring-the-dependency is a good compromise from our experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants