adouble: avoid entry bounds overflow - #3219
Merged
Merged
Conversation
validate AppleDouble entry lengths with subtraction after checking the offset, preventing 32-bit addition from wrapping while preserving the resource-fork exception Ref. GHSA-mhfg-rppv-24g6 Reported-by: Elias Hasas (@zer0d4y5) Signed-off-by: Daniel Markstedt <daniel@mindani.net>
🤖 Augment PR SummarySummary: Hardens AppleDouble entry parsing by validating entry lengths using subtraction after the offset check, avoiding 32-bit wraparound. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
Contributor
📊 Performance DashboardCommit: 🔥 Spectest (AFP 3.4) - FlameGraphNetatalk Code-time: 1.9% · Runtime: 68s · Stacks: 1124 🔥 Click the preview to open the interactive flamegraph (zoom + search). 🔝 Top 10 leaf functions
📈 Speedtest (AFP 3.4) - PerfGraph🔝 Throughputs per operation
⏱️ Lantest (AFP 3.4) - LatencyGraphAvg total runtime: 10694 ms · Avg time per AFP op: 0.155 ms 🐢 All operations (avg runtime, in test order)
|
andylemin
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate AppleDouble entry lengths with subtraction after checking the offset, preventing 32-bit addition from wrapping while preserving the resource-fork exception
Ref. GHSA-mhfg-rppv-24g6
Reported-by: Elias Hasas (@zer0d4y5)