refactor: convert adf_lock macros to functions #2645
+70
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors adf_lock_init and adf_lock_free from macros to proper functions to improve static analysis capability and code maintainability. Adds defensive NULL checks with error logging. Fixes #2600
|
rdmark
approved these changes
Jan 19, 2026
Member
rdmark
left a comment
rdmark
left a comment
There was a problem hiding this comment.
much cleaner!
one could argue that ad_lock.h has served its purpose and could just as well be refactored away now, but what do you think?
Contributor
Author
|
Agreed, I'll add it here. And yes, the static analyser is working now - it raised some other minor things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors adf_lock_init and adf_lock_free from macros to proper functions to improve static analysis capability and code maintainability.
Adds defensive NULL checks with error logging.
Fixes #2600