Skip to content

Fix issue with empty string value on association key #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue with empty string value on association key #30

wants to merge 1 commit into from

Conversation

iloveitaly
Copy link
Member

Normally this would trigger a fatal error. This is related to 34e2965

This revised implementation of the netsuite_extract_from_record function properly handles:

  • boolean values. true/false values from netsuite will properly set the AR model
  • association fields with empty string. An empty string on an association field will nil-out the association reference
  • unset custom fields. If a custom field does not exist on a record, a blank value is used

@iloveitaly
Fix issue with empty string value on an association key would trigger…
5f06b0f 
… a fatal error

This revised implementation of the netsuite_extract_from_record function properly handles:

* boolean values. true/false values from netsuite will properly set the AR model
* association fields with empty string. An empty string on an association field will nil-out the association reference
* unset custom fields. If a custom field does not exist on a record, a blank value is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iloveitaly