Skip to content

update: regularModule add __doBuild function, and can assign __export info #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shhider
Copy link

@shhider shhider commented Sep 4, 2016

现在的regularModule无法设置__export属性,以指定子模块容器,即失去了私有模块的功能。本PR即添加该功能。

添加过程中有考虑过允许regularModule子类直接在声明、或config方法中直接指定子模块容器。但根据Regular的生命周期,在config方法执行完后,才有初始化的DOM元素。因此只能在init方法以及之后进行。

然后看到regularModule的父类_$$ModuleAbstract的代码,组合模块的逻辑在__onShow__onRefresh调用;而regularModule中__onShow__onRefresh先执行了父方法。因此使用时在__onShow__onRefresh时指定也不行。

所以只能放目光放在regularModule的__build方法,并结合NEJ模块的风格,向regularModule子类提供了__doBuild方法,在该方法中可以指定子模块容器和其他开放信息(即__export)。具体逻辑可见代码。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant