Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds getter methods for read timeout and minimum number of characters to read settings, refactors the timeout handling mechanism, and updates tests accordingly.
- Adds
getReadTimeout()andgetMinNumberCharRead()methods to retrieve current serial port configuration - Removes redundant
timeout_member variable and modifiessetTimeOut()to directly use the parameter value - Updates
setReadTimeout()to call the internalsetTimeOut()method for consistency - Comments out a previously failing test (
SetTermios2WithFail) and adds two new tests for the getter methods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| include/libserial/serial.hpp | Adds public getter method declarations for read timeout and minimum character read settings; removes redundant timeout_ member variable documentation |
| src/serial.cpp | Implements the new getter methods; refactors setTimeOut() to remove member variable assignment; updates setReadTimeout() to call setTimeOut() |
| test/test_serial_pty.cpp | Comments out failing SetTermios2WithFail test; adds new tests for SetGetReadTimeout and SetGetMinNumberCharRead |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Details
How to test
Screenshots/Logs (optional)
Checklist
make cppcheck/make cpplint/make uncrustifyRisks and rollbacks