-
Notifications
You must be signed in to change notification settings - Fork 4.9k
chore: action update #17993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: action update #17993
Conversation
""" Walkthrough本次更改主要涉及 GitHub Issue 模板、标签配置、工作流和贡献指南文档。具体包括调整 Issue 模板的标题和标签、优化描述文案、扩展自动标签器的匹配范围、升级 Codecov Action 版本,以及修改文档代码块的语法高亮标记。 Changes
Sequence Diagram(s)sequenceDiagram
participant User as 用户
participant GitHub as GitHub
participant Labeler as 标签器
User->>GitHub: 提交 Issue(选择模板)
GitHub->>Labeler: 根据模板内容自动打标签(包含所有平台/所有小程序等新 key)
Labeler-->>GitHub: 返回匹配标签
GitHub-->>User: 展示带新标签的 Issue
Possibly related PRs
Suggested reviewers
Poem
""" ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/ISSUE_TEMPLATE/config.yml (1)
17-17
: 保持标点风格一致性
此处仅新增了一个感叹号,整体无功能性影响,但建议检查其它模板的about
字段,确保同类描述的结尾标点一致,避免视觉不统一。.github/ISSUE_TEMPLATE/bug_report.yml (1)
104-104
: 链接语法 OK,但可考虑加空格避免渲染歧义
当前 Markdown 渲染正常,不过在 “[(贡献指南)]” 前后保留空格能进一步降低意外解析风险。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/ISSUE_TEMPLATE/bug_report.yml
(1 hunks).github/ISSUE_TEMPLATE/config.yml
(1 hunks).github/ISSUE_TEMPLATE/feature_request.yml
(2 hunks).github/advanced-issue-labeler.yml
(1 hunks).github/workflows/nodejs.yml
(1 hunks)CONTRIBUTING.md
(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: ianzone
PR: NervJS/taro#17937
File: .github/workflows/issue-labeler.yml:31-31
Timestamp: 2025-07-01T15:46:08.457Z
Learning: stefanbuck/github-issue-parser@v3 GitHub Action 的输出字段名称是 `jsonString`,不是 `json`。在工作流中应该使用 `${{ steps.issue-parser.outputs.jsonString }}` 来引用解析后的 JSON 数据。
Learnt from: ianzone
PR: NervJS/taro#17937
File: .github/advanced-issue-labeler.yml:17-63
Timestamp: 2025-07-01T15:49:00.336Z
Learning: In GitHub repositories, labels must be created by repository administrators before they can be configured in advanced-issue-labeler.yml. The labeler configuration can only map to existing labels, so missing platform options like "ASCF 元服务" and "支付宝 IOT 小程序" require admin action to create corresponding labels first.
CONTRIBUTING.md (1)
Learnt from: ianzone
PR: NervJS/taro#17842
File: packages/jest-helper/tsconfig.json:9-9
Timestamp: 2025-06-23T00:09:31.233Z
Learning: 在 jest-helper 包中,src 目录下没有 __tests__ 测试目录,只包含 resolver.ts、sequencer.ts 和 snapshot 目录。不要假设包中存在测试目录结构。
.github/ISSUE_TEMPLATE/feature_request.yml (1)
Learnt from: ianzone
PR: NervJS/taro#17937
File: .github/advanced-issue-labeler.yml:17-63
Timestamp: 2025-07-01T15:49:00.336Z
Learning: In GitHub repositories, labels must be created by repository administrators before they can be configured in advanced-issue-labeler.yml. The labeler configuration can only map to existing labels, so missing platform options like "ASCF 元服务" and "支付宝 IOT 小程序" require admin action to create corresponding labels first.
.github/advanced-issue-labeler.yml (1)
Learnt from: ianzone
PR: NervJS/taro#17937
File: .github/advanced-issue-labeler.yml:17-63
Timestamp: 2025-07-01T15:49:00.336Z
Learning: In GitHub repositories, labels must be created by repository administrators before they can be configured in advanced-issue-labeler.yml. The labeler configuration can only map to existing labels, so missing platform options like "ASCF 元服务" and "支付宝 IOT 小程序" require admin action to create corresponding labels first.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
- GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
- GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-gnu
- GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
- GitHub Check: Build Rust WASM / stable - wasm32-wasi
🔇 Additional comments (4)
.github/workflows/nodejs.yml (1)
118-150
: 确认 Codecov Action v5 的参数兼容性
已将codecov/codecov-action
升级至 v5,但 v5 对若干输入参数及默认行为(如fail_ci_if_error
、upload_name
等)有细微变动。请确认:
- 现有
flags
、files
、token
参数在 v5 中仍被支持且含义一致。- 如需保持遇到上传失败即 CI 报错的语义,请显式添加
fail_ci_if_error: true
。- 若仓库为公有仓库,可考虑去掉
token
,以减少权限暴露。示例修订:
- uses: codecov/codecov-action@v5 + uses: codecov/codecov-action@v5 + with: + fail_ci_if_error: trueCONTRIBUTING.md (1)
64-71
: 代码块语言高亮已更新,👍
将json
改为js
更贴合实际文件类型,阅读体验更佳。.github/ISSUE_TEMPLATE/feature_request.yml (2)
25-25
: 措辞优化已确认,无需进一步调整
调整后的描述更准确,保持现有实现即可。
38-38
: 请确认复选框标签中的 Markdown 链接渲染效果
Issue Forms 的复选框标签理论上支持 Markdown,但不同渲染环境可能仅显示纯文本。建议在 PR 界面预览模板,确保链接正常可点击,避免用户界面混淆。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17993 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 417 417
Lines 21693 21693
Branches 5383 5358 -25
=======================================
Hits 11928 11928
- Misses 8084 8121 +37
+ Partials 1681 1644 -37
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/auto-review.yml (2)
21-26
: 写入$GITHUB_ENV
的脚本可以更简洁并避免潜在转义问题
当前通过echo
拼接 here-doc,在包含特殊字符(如\
,$
,`
)或极端情况下 commit message 内部本身出现EOF
时仍有概率被误解析。可用printf
配合显式 here-doc 令实现更健壮,示例:- { - echo "commit_msg<<EOF" - echo "${COMMIT_MESSAGE}" - echo "EOF" - } >> "$GITHUB_ENV" + { + printf 'commit_msg<<EOF\n%s\nEOF\n' "$COMMIT_MESSAGE" + } >> "$GITHUB_ENV"同时推荐统一使用大写环境变量(如
COMMIT_MSG
),以符合常见 POSIX 约定。
31-31
: 条件判断可改为不区分大小写,提高容错
目前contains(env.commit_msg, '[auto review]')
仅匹配完全小写形式;若提交信息写成[Auto Review]
将被漏判。可利用toLower()
进行大小写归一化:- if: contains( env.commit_msg , '[auto review]' ) || contains(github.event.pull_request.title, '[auto review]') + if: contains( toLower(env.commit_msg) , '[auto review]' ) || contains( toLower(github.event.pull_request.title) , '[auto review]' )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/dependabot.yml
(1 hunks).github/workflows/auto-review.yml
(1 hunks).github/workflows/build-rust-binding.yml
(2 hunks).github/workflows/build-rust-wasm.yml
(1 hunks).github/workflows/nodejs.yml
(3 hunks).github/workflows/publish.yml
(2 hunks).github/workflows/sync-components-types.yml
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- .github/workflows/build-rust-wasm.yml
- .github/workflows/publish.yml
- .github/workflows/sync-components-types.yml
- .github/dependabot.yml
- .github/workflows/build-rust-binding.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/nodejs.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ianzone
PR: NervJS/taro#17993
File: .github/advanced-issue-labeler.yml:20-63
Timestamp: 2025-07-11T14:04:05.533Z
Learning: 在 NervJS/taro 项目的 .github/advanced-issue-labeler.yml 中,平台标签被设计为可以多个共存。当用户选择"所有平台"时,系统会同时应用多个平台标签(如 T-h5, T-rn, T-weapp 等),这是期望的行为而非冲突。同样,"所有小程序"也会为小程序相关的标签应用多个标签。这种设计有助于跨平台问题的管理和维护者关注。
Learnt from: ianzone
PR: NervJS/taro#17937
File: .github/workflows/issue-labeler.yml:31-31
Timestamp: 2025-07-01T15:46:08.457Z
Learning: stefanbuck/github-issue-parser@v3 GitHub Action 的输出字段名称是 `jsonString`,不是 `json`。在工作流中应该使用 `${{ steps.issue-parser.outputs.jsonString }}` 来引用解析后的 JSON 数据。
Learnt from: ianzone
PR: NervJS/taro#17937
File: .github/advanced-issue-labeler.yml:17-63
Timestamp: 2025-07-01T15:49:00.336Z
Learning: In GitHub repositories, labels must be created by repository administrators before they can be configured in advanced-issue-labeler.yml. The labeler configuration can only map to existing labels, so missing platform options like "ASCF 元服务" and "支付宝 IOT 小程序" require admin action to create corresponding labels first.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
- GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
- GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-musl
- GitHub Check: Build Rust Binding / stable - x86_64-unknown-linux-gnu
- GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
- GitHub Check: Build Rust WASM / stable - wasm32-wasi
🔇 Additional comments (1)
.github/workflows/auto-review.yml (1)
28-28
: 确认变量命名保持一致
此处引用的是$commit_msg
(小写),与上一步写入的同名变量保持一致即可;如采纳上一条建议改为大写,请同步调整这里的引用。
@yoyo837 一些CI升级,帮忙合一下哈 |
这个 PR 做了什么? (简要描述所做更改)
issue中让“所有平台”和“所有小程序”也可以打标签。
各种 action 依赖项升级
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit
文档
杂项