Publish/4.1.2 #17804
Publish/4.1.2 #17804
Conversation
|
Warning Rate limit exceeded@Single-Dancer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 32 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Walkthrough此次更改重构并精简了 GitHub Actions 工作流，移除了所有 Rust 相关构建、测试和发布前校验，仅保留单一的发布流程。发布流程被简化为在 Ubuntu 上依次发布多个 npm 包，并在合并 PR 后自动创建 Release。部分包配置了公开发布权限。 Changes
Sequence Diagram(s)sequenceDiagram
actor Developer
participant GitHub Actions
participant NPM Registry
participant GitHub Releases
Developer->>GitHub Actions: Push/PR merge到指定分支
GitHub Actions->>GitHub Actions: 依次发布多个npm包
loop 对每个包
GitHub Actions->>NPM Registry: 发布包
end
alt PR合并事件
GitHub Actions->>GitHub Releases: 创建Release
GitHub Actions->>Developer: PR评论发布Release链接
end
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
.github/workflows/publish.yml (1)
139-139: 升级 actions/github-script 版本
actions/github-script@v6已过时，可能导致兼容性问题。建议升级至最新主线版本（如actions/github-script@v7）。🧰 Tools
🪛 actionlint (1.7.7)
139-139: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/nodejs.yml (2)
70-79: 移除未使用的发布参数获取已通过
grep提取并设置PUBLISH_PARAMS环境变量，但未在后续步骤中使用。建议删除相关步骤，或将其应用于发布命令中。
139-139: 升级 actions/github-script 版本同
publish.yml建议，将actions/github-script@v6升级至最新版本以保证兼容性。🧰 Tools
🪛 actionlint (1.7.7)
139-139: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/nodejs.yml(2 hunks).github/workflows/publish.yml(1 hunks)packages/taro-platform-ascf/package.json(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/nodejs.yml
139-139: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Publish
- GitHub Check: Publish
🔇 Additional comments (3)
packages/taro-platform-ascf/package.json (1)
39-42: 验证发布配置
publishConfig.access已正确设置为public，符合公开发布需求。.github/workflows/publish.yml (1)
112-115: 校验 pnpm 发布命令参数合法性当前使用
pnpm publish --publish-branch=${{ github.ref_name }}，但官方文档并未提及--publish-branch选项。请确认该参数是否生效，或替换为正确的--tag或其他合法参数。.github/workflows/nodejs.yml (1)
112-115: 校验 pnpm 发布命令参数合法性同
publish.yml中指出，--publish-branch似非官方支持选项，需确认或替换为正确的--tag等参数。
.github/workflows/nodejs.yml
Outdated
| CURRENT_VERSION: '' | ||
| PUBLISH_PARAMS: '' | ||
| steps: |
There was a problem hiding this comment.
缺少版本提取步骤
在 env 中定义了 CURRENT_VERSION，但未实际从 package.json 或其他来源赋值，会导致后续创建 Release 时标签为空。请补充版本提取逻辑。
🤖 Prompt for AI Agents
In .github/workflows/nodejs.yml around lines 31 to 33, the environment variable
CURRENT_VERSION is defined but not assigned any value, causing the release tag
to be empty. Add a step before using CURRENT_VERSION to extract the version from
package.json (e.g., using a command like `CURRENT_VERSION=$(node -p
"require('./package.json').version")`) and set it as an environment variable so
that it can be used properly in subsequent steps.
| on: | ||
| push: |
There was a problem hiding this comment.
警告：重复的发布工作流
nodejs.yml 中的发布逻辑与 publish.yml 几乎一致，可能导致重复触发与重复发布。建议合并或删除冗余工作流，降低维护成本并避免二次发布。
🤖 Prompt for AI Agents
In .github/workflows/nodejs.yml at lines 1 to 2, the publish workflow duplicates
the logic found in publish.yml, which can cause redundant triggers and duplicate
releases. Review both workflows and either merge their logic into a single
workflow or delete one of them to avoid duplication, reduce maintenance
overhead, and prevent multiple releases.
Single-Dancer
force-pushed
the
publish/4.1.2
branch
from
fbe139c to
756dda6
Compare
这个 PR 做了什么？ (简要描述所做更改)
这个 PR 是什么类型？ (至少选择一个)
这个 PR 涉及以下平台：
Summary by CodeRabbit
@tarojs/plugin-platform-ascf包配置为以公开模式发布。