Fix leaking pyplot figure handle in ConceptsWindow #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation does not say this very prominently, but under the documentation for `pyplot.close()` (https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.close.html), it states that this needs to happen if figures are not displayed using `pyplot.show()`, which we, nor the TK wrappers, appear to be doing. This fixes a warning message about a potential leak that is printed to the console once you have opened quite a few figures. Steps to reproduce: 1. Create many concepts (25?) 2. For each concept, open the concept window, open the statistics tab, close the concept window. 3. Look at the OneTrainer console output for a warning message related to this.
dxqb
reviewed
Jan 18, 2026
| self.bucket_ax.yaxis.label.set_color(self.text_color) | ||
|
|
||
| # Close any previous figure handle (if we had one) | ||
| if prev_bucket_fig is not None: |
Collaborator
There was a problem hiding this comment.
can this ever happen?
isn't this function only called once during initialization of the window?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does not say this very prominently, but under the documentation for
pyplot.close()(https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.close.html), it states that this needs to happen if figures are not displayed usingpyplot.show(), which we, nor the TK wrappers, appear to be doing.This fixes a warning message about a potential leak that is printed to the console once you have opened quite a few figures.
Steps to reproduce: